OTWO-4919 Edit page search not working for enist and rss - #1919
Open
Niharika1117 wants to merge 1 commit into
Open
OTWO-4919 Edit page search not working for enist and rss#1919Niharika1117 wants to merge 1 commit into
Niharika1117 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes edit-page search behavior for edits that don’t populate key/value (notably CreateEdit rows for targets like Enlistments and RSS subscriptions) by allowing searches to match against edits.target_type.
Changes:
- Expand
Edit.filterable_byto includetarget_type, enabling queries like “rsssubscription” to matchCreateEditrows. - Add a controller test ensuring the edits index can find RSS subscription edits via
target_typesearch. - Fix a helper test assertion to compare the current year as a string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/helpers/edits_helper_test.rb | Fixes year-matching assertion to compare against a string. |
| test/controllers/edits_controller_test.rb | Adds coverage ensuring edits search can find RSS subscription CreateEdit records. |
| app/models/edit.rb | Adds target_type to searchable attributes used by filter_by. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.