Add capture event transport and server-side write classification#112
Open
jspahn80134 wants to merge 27 commits into
Open
Add capture event transport and server-side write classification#112jspahn80134 wants to merge 27 commits into
jspahn80134 wants to merge 27 commits into
Conversation
Update the ignored PostgreSQL integration test to assert the rich events schema columns and fix timestamp/JSONB parameter casts used by the capture insert path. Verified against the AWS PostgreSQL database with event_capture_inserts_rich_schema_event_into_db.
macOS CI occasionally delivered the loadfile acknowledgement just after the old two-second harness timeout. Increase the shared browser message wait to five seconds so test_client does not fail on that timing edge.
The first CI rerun passed the original test_client wait but exposed the same timing issue in test_client_updates while waiting for the autosave content update. Use the client response window as the shared browser test wait budget.
The overall browser tests share one WebDriver endpoint and were running concurrently inside the same test binary. This was causing test_client_updates to miss its autosave content update on CI, especially macOS/Safari. Guard the harness with a shared async mutex so each browser session runs in isolation.
bjones1
reviewed
May 11, 2026
Owner
bjones1
left a comment
bjones1
left a comment
There was a problem hiding this comment.
Here's some initial comments on the PR, mainly questions -- I'd like to hear your thoughts. I'll continue to review.
| // CAPTURE (Dissertation instrumentation) | ||
| // -------------------------------------- | ||
|
|
||
| function isInMarkdownCodeFence( |
Owner
There was a problem hiding this comment.
I don't understand the purpose of these functions. They seems to assume that the source code is Markdown/reStructuredText with code in code blocks, but source code is just plain source code. Why is this used?
Use generated Rust-backed capture wire/status types in the VS Code extension. Restore the explanatory extension comments and the current-file update after LoadFile. Keep study lifecycle commands available for automation while removing them from the Command Palette.
Resolve conflicts in the VS Code extension, translation capture path, and overall test harness. Keep upstream CursorPosition/WebDriver updates while preserving capture instrumentation and serialized browser test timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation: