Conversation
Replaces package-lock.json with pnpm-lock.yaml and adds pnpm-workspace.yaml to allow build scripts for @parcel/watcher and esbuild, which pnpm blocks by default. Declares vue as a peerDependency per the VuePress getting-started guide: with pnpm's strict node_modules layout, vue isn't hoisted to the root, so Vite's import-analysis fails to resolve `import "vue"` from @vuepress/client.
Add pnpm/action-setup before setup-node so pnpm is on PATH for the built-in lockfile cache (cache: pnpm), then install with `pnpm install --frozen-lockfile` and run the lint script via pnpm. Follows https://pnpm.io/continuous-integration#github-actions.
Deploying passwordless-docs with
|
| Latest commit: |
cda0297
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ded2a956.passwordless-docs.pages.dev |
| Branch Preview URL: | https://pnpm.passwordless-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Migrate the project from npm to pnpm. Replaces
package-lock.jsonwithpnpm-lock.yaml, addspnpm-workspace.yaml, and updates CI to install with pnpm.Shape
package-lock.jsonand addedpnpm-lock.yaml.@parcel/watcherandesbuild, which pnpm blocks by default.vueas a peerDependency: With pnpm's strictnode_moduleslayout, VuePress's transitivevueisn't hoisted to the root, so Vite's import-analysis fails to resolveimport "vue"from@vuepress/client. Declaringvueas a peer dependency per the VuePress getting-started guide makes it resolvable.pnpm/action-setup(SHA-pinned to v6.0.3) beforesetup-node, enabledcache: pnpmfor lockfile-based caching, and swappednpm ci/npm run lint:checkforpnpm install --frozen-lockfile/pnpm run lint:check. Follows the pnpm CI guide.Checklist
I did the following to ensure that my changes were tested thoroughly:
pnpm installandpnpm devlocally and confirmed the dev server starts without the previousFailed to resolve import "vue"error.pnpm run lint:checklocally.I did the following to ensure that my changes do not introduce security vulnerabilities:
pnpm/action-setupto a commit SHA (v6.0.3) in line with the existing SHA-pinning convention foractions/checkoutandactions/setup-node.