Skip to content

[PM-43140] fix(browser): detect old password fields in change forms - #23030

Open
tmsteph wants to merge 1 commit into
bitwarden:mainfrom
tmsteph:fix/detect-old-password-change
Open

[PM-43140] fix(browser): detect old password fields in change forms#23030
tmsteph wants to merge 1 commit into
bitwarden:mainfrom
tmsteph:fix/detect-old-password-change

Conversation

@tmsteph

@tmsteph tmsteph commented Sep 6, 2026

Copy link
Copy Markdown

🎟️ Tracking

Relates to #1620

📔 Objective

Password-change and password-expiry forms commonly use fields such as oldPassword, currentPassword, newPassword, and a confirmation field.

Bitwarden already has change-password notification logic for password + newPassword, but the current-password classifier only recognized spaced phrases such as current password. Compact field names like oldPassword or currentPassword therefore could fall through classification on multi-password forms and never be captured as the current password.

Add conservative current-password / old-password keyword variants to the password-update classifier. Bitwarden's existing tokenizer removes hyphens, so these variants match compact field names (currentPassword, oldPassword) without broad fuzzy matching.

The regression test covers an expired/change-password style form with oldPassword, newPassword, and confirmation fields and verifies that the old-password field is classified as CurrentPasswordUpdate.

Validation:

  • git diff --check
  • patch applies cleanly to current main
  • verified tokenizer behavior: old-password -> oldpassword, matching oldPassword

I did not run the full browser test suite locally because the monorepo dependency install previously exhausted the available worker resources. CI can provide full project validation.

📸 Screenshots

Not applicable. This changes form-field classification only and reuses Bitwarden's existing change-password UI/notification flow.

Signed-off-by: Thomas Stephens <tmsteph1290@gmail.com>
@tmsteph
tmsteph requested a review from a team as a code owner September 6, 2026 15:10
@tmsteph
tmsteph requested a review from blackwood September 6, 2026 15:10
@bitwarden-bot

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-43140
Link: https://bitwarden.atlassian.net/browse/PM-43140

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title fix(browser): detect old password fields in change forms [PM-43140] fix(browser): detect old password fields in change forms Sep 6, 2026
@bitwarden-bot bitwarden-bot added community-pr needs-qa Marks a PR as requiring QA approval labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-pr needs-qa Marks a PR as requiring QA approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants