[PM-43138] fix(browser): show save login after generated password - #23028
Open
tmsteph wants to merge 1 commit into
Open
[PM-43138] fix(browser): show save login after generated password#23028tmsteph wants to merge 1 commit into
tmsteph wants to merge 1 commit into
Conversation
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Fixes #18167
📔 Objective
When a password is generated from the inline autofill menu, the generated value is recorded, but the inline list is closed by the resulting input event. Because the password field can remain focused, there may be no later focus event to reopen the inline menu and expose the existing Save to Bitwarden view.
After
generatedPasswordFilledis recorded, requestopenAutofillInlineMenuagain. This reuses the existing filled-field logic and save-login UI rather than introducing a new save path or automatically writing to the vault.The regression assertion verifies that the generated-password handler first records
generatedPasswordFilledand then requests the inline menu to reopen.Validation performed locally:
git apply --checkgit diff --checkbitwarden/clientsmainI did not run the full browser test suite locally because installing the monorepo dependency set exhausted the available worker resources. CI can provide the full project validation.
📸 Screenshots
Not included: this does not add or restyle UI; it reopens Bitwarden's existing filled-field Save to Bitwarden inline-menu state after generated-password fill.