[PM-43130] fix(importer): preserve 1pux vault structure as folders/collections on import - #23025
Draft
matellis wants to merge 1 commit into
Draft
[PM-43130] fix(importer): preserve 1pux vault structure as folders/collections on import#23025matellis wants to merge 1 commit into
matellis wants to merge 1 commit into
Conversation
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20724.
Problem
The 1pux importer discards all vault structure. Every item from every vault lands in a flat, unorganised list. A TODO comment in the parser marks where multi-vault handling was intended but never completed.
Change
attrs.nameintoprocessOverviewas the folder name, for every vault regardless of type (Personal P, Everyone/Shared E, and user-created U vaults all hold real items).VaultName/TagName; untagged items getVaultName.moveFoldersToCollectionsalready promotes vault folders to collections automatically.VaultAttributeTypeEnumreference (that enum was never defined).Testing
SanitizedExportfixture items now land in"T's Test Vault/Movies"etc. instead of bare"Movies", and the second vault ("Personal") is correctly surfaced.