[PM-43081] Hide the Shared folders filter on My items - #23017
[PM-43081] Hide the Shared folders filter on My items#23017gbubemismith wants to merge 2 commits into
Conversation
The Shared folders chip and column were shown on an organization's "My items" page, which is one member's own collection. showSharedFolders was driven by organizations().length > 0 alone, true there because the org is in scope. "My items" is now a dimension of the vault scope instead of a route sentinel that resolution trades away: VaultScope's Organization member gains myItems, collectionId narrows to a plain CollectionId, and the flag survives resolveVaultScope. That also fixes a latent bug — a resolved My items scope used to build /vault/:orgId/shared-folders/:collectionId. The table takes a scopedToMyItems input, kept separate from noSharedFolderOptions so a chip with no options still disables rather than disappears.
…y-items # Conflicts: # apps/web/src/app/vault/individual-vault/vault-next.component.ts
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the Code Review DetailsNo findings. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23017 +/- ##
=======================================
Coverage 55.57% 55.58%
=======================================
Files 4412 4412
Lines 140965 140975 +10
Branches 22392 22394 +2
=======================================
+ Hits 78348 78356 +8
- Misses 56916 56918 +2
Partials 5701 5701 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-43081
📔 Objective
The Shared folders chip and column were shown on an organization's "My items" page, which is one member's own collection.
showSharedFolderswas driven byorganizations().length > 0alone, true there because the org is in scope."My items" is now a dimension of the vault scope instead of a route sentinel that resolution trades away:
VaultScope's Organization member gainsmyItems?: boolean,collectionIdnarrows to a plainCollectionId, and the flag survivesresolveVaultScope. That also fixes a latent bug — a resolved My items scope used to build/vault/:orgId/shared-folders/:defaultCollectionId.The table takes a
scopedToMyItemsinput, kept separate fromnoSharedFolderOptionsso a chip with no options still disables rather than disappears.📸 Screenshots
Screen.Recording.2026-09-04.at.16.29.07.mov