Skip to content

[PM-43081] Hide the Shared folders filter on My items - #23017

Draft
gbubemismith wants to merge 2 commits into
mainfrom
vault/pm-43081/hide-shared-folders-chip-on-my-items
Draft

[PM-43081] Hide the Shared folders filter on My items#23017
gbubemismith wants to merge 2 commits into
mainfrom
vault/pm-43081/hide-shared-folders-chip-on-my-items

Conversation

@gbubemismith

@gbubemismith gbubemismith commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-43081

📔 Objective

The Shared folders chip and column were shown on an organization's "My items" page, which is one member's own collection. showSharedFolders was driven by organizations().length > 0 alone, true there because the org is in scope.

"My items" is now a dimension of the vault scope instead of a route sentinel that resolution trades away: VaultScope's Organization member gains myItems?: boolean, collectionId narrows to a plain CollectionId, and the flag survives resolveVaultScope. That also fixes a latent bug — a resolved My items scope used to build /vault/:orgId/shared-folders/:defaultCollectionId.

The table takes a scopedToMyItems input, kept separate from noSharedFolderOptions so a chip with no options still disables rather than disappears.

📸 Screenshots

Screen.Recording.2026-09-04.at.16.29.07.mov

The Shared folders chip and column were shown on an organization's "My
items" page, which is one member's own collection. showSharedFolders was
driven by organizations().length > 0 alone, true there because the org is
in scope.

"My items" is now a dimension of the vault scope instead of a route
sentinel that resolution trades away: VaultScope's Organization member
gains myItems, collectionId narrows to a plain CollectionId, and the flag
survives resolveVaultScope. That also fixes a latent bug — a resolved My
items scope used to build /vault/:orgId/shared-folders/:collectionId.

The table takes a scopedToMyItems input, kept separate from
noSharedFolderOptions so a chip with no options still disables rather
than disappears.
@gbubemismith gbubemismith added the ai-review Request a Claude code review label Sep 4, 2026
@gbubemismith gbubemismith changed the title [PM-43081] fix: Hide the Shared folders filter on My items [PM-43081] Hide the Shared folders filter on My items Sep 4, 2026
@gbubemismith gbubemismith added the t:bugfix Change Type - Bugfix label Sep 4, 2026
…y-items

# Conflicts:
#	apps/web/src/app/vault/individual-vault/vault-next.component.ts
@gbubemismith
gbubemismith marked this pull request as ready for review September 4, 2026 20:33
@gbubemismith
gbubemismith requested a review from a team as a code owner September 4, 2026 20:33
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the VaultScope model change that replaces the MY_ITEMS_ROUTE sentinel on collectionId with a separate myItems flag, along with its consumers: parseVaultScope/resolveVaultScope/vaultScopeCommands/cipherInScope, the vault scope guard, the shared folder card grid, the side nav, and the new scopedToMyItems input threaded from the web and desktop hosts into VaultItemsTableComponent. Traced the sentinel's former behaviour against the new flag in each branch — an unresolved My items scope still matches no ciphers, a resolved one still narrows to the default user collection, and vaultScopeCommands now prefers the my-items segment once resolved, which is the latent routing bug the description calls out. Confirmed no remaining references to the removed ScopedCollectionId type or to collectionId === MY_ITEMS_ROUTE anywhere in the repo, and that both hosts rendering vault-items-table pass the new input. Unit tests cover the new isMyItemsScope helper, the resolved/unresolved scope commands, and the hidden Shared folders chip and column.

Code Review Details

No findings.

@gbubemismith
gbubemismith marked this pull request as draft September 4, 2026 20:45
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.58%. Comparing base (b57513e) to head (4e1aa05).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...der-card-grid/shared-folder-card-grid.component.ts 33.33% 1 Missing and 1 partial ⚠️
.../desktop/src/vault/app/vault-v3/vault.component.ts 0.00% 1 Missing ⚠️
libs/vault/src/models/vault-scope.ts 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23017   +/-   ##
=======================================
  Coverage   55.57%   55.58%           
=======================================
  Files        4412     4412           
  Lines      140965   140975   +10     
  Branches    22392    22394    +2     
=======================================
+ Hits        78348    78356    +8     
- Misses      56916    56918    +2     
  Partials     5701     5701           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant