Skip to content

[PM-42825] Filter out provider organizations - #23016

Draft
nick-livefront wants to merge 1 commit into
mainfrom
vault/pm-42825/member-orgs
Draft

[PM-42825] Filter out provider organizations#23016
nick-livefront wants to merge 1 commit into
mainfrom
vault/pm-42825/member-orgs

Conversation

@nick-livefront

@nick-livefront nick-livefront commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-42825

📔 Objective

Swap out usages of organizations$ to memberOrganizations$ to avoid showing organizations where users can only access via a Provider.

Stems from claude's feedback here: #22761 (comment)

@nick-livefront nick-livefront added ai-review Request a Claude code review t:bugfix Change Type - Bugfix labels Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a three-file bugfix that swaps organizationService.organizations$ for memberOrganizations$ in the desktop vault-v3 component and the web VaultNextComponent, plus the corresponding test mock. memberOrganizations$ is organizations$ filtered by Organization.isMember, so provider-only organizations are excluded — matching the intent in the linked PM-42825 task. This aligns both components with the rest of the individual-vault surfaces (vault-filter.service.ts, default-vault-nav.service.ts, vault-popup-list-filters.service.ts), which already use memberOrganizations$. Downstream consumers in both components (organization name resolution for the Vault column/chip, selectedOrganization$, scopedOrganizations) only read organizations the individual vault can surface items for, and the desktop component has no spec that mocks the old method, so no other test updates are needed.

No findings.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.59%. Comparing base (749e32e) to head (50df9cc).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../desktop/src/vault/app/vault-v3/vault.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23016   +/-   ##
=======================================
  Coverage   55.59%   55.59%           
=======================================
  Files        4411     4411           
  Lines      140848   140877   +29     
  Branches    22370    22376    +6     
=======================================
+ Hits        78298    78324   +26     
- Misses      56852    56854    +2     
- Partials     5698     5699    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant