Skip to content

fix(pam): give the rotation sub-pages a readable breadcrumb trail - #23007

Draft
maxkpower wants to merge 3 commits into
pam/rotation-row-menusfrom
pam/rotation-page-breadcrumbs
Draft

fix(pam): give the rotation sub-pages a readable breadcrumb trail#23007
maxkpower wants to merge 3 commits into
pam/rotation-row-menusfrom
pam/rotation-page-breadcrumbs

Conversation

@maxkpower

Copy link
Copy Markdown
Contributor

Design review 2026-09-04: "it's not clear to me that these are breadcrumbs at all". A one-item trail with no separator reads as a caption. Same construction as the access-rule edit page, including not promoting the last crumb to the page heading.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.06%. Comparing base (a660080) to head (6398e0f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-web/src/app/pam/rotation/testing/story-helpers.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           pam/rotation-row-menus   #23007   +/-   ##
=======================================================
  Coverage                   56.06%   56.06%           
=======================================================
  Files                        4468     4469    +1     
  Lines                      143108   143113    +5     
  Branches                    22593    22593           
=======================================================
+ Hits                        80234    80237    +3     
- Misses                      57129    57133    +4     
+ Partials                     5745     5743    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant