Skip to content

fix(pam): align the rotation row menus with the design - #23006

Draft
maxkpower wants to merge 4 commits into
pam/rotation-access-connectors-vocabularyfrom
pam/rotation-row-menus
Draft

fix(pam): align the rotation row menus with the design#23006
maxkpower wants to merge 4 commits into
pam/rotation-access-connectors-vocabularyfrom
pam/rotation-row-menus

Conversation

@maxkpower

Copy link
Copy Markdown
Contributor

Design review 2026-09-04, three before/after screenshots. Object-specific labels, designed order, and a divider before the destructive item.

Two rulings a reviewer should check: the design's "Revoke access connector" is NOT implemented, because revoke was deliberately replaced by disable/enable plus delete in a 2026-07-10 commit, and Deactivate on targets sits beside Disable on connectors on purpose, since the connector pair matches the badge on its row.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.06%. Comparing base (f6094b5) to head (a660080).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ion/target-systems/target-systems-tab.component.ts 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           pam/rotation-access-connectors-vocabulary   #23006   +/-   ##
==========================================================================
  Coverage                                      56.05%   56.06%           
==========================================================================
  Files                                           4467     4468    +1     
  Lines                                         143072   143108   +36     
  Branches                                       22589    22593    +4     
==========================================================================
+ Hits                                           80202    80234   +32     
+ Misses                                         57130    57129    -1     
- Partials                                        5740     5745    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant