fix(pam): rename the rotation daemons surface to access connectors - #23005
Draft
maxkpower wants to merge 3 commits into
Draft
fix(pam): rename the rotation daemons surface to access connectors#23005maxkpower wants to merge 3 commits into
maxkpower wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pam/rotation-credentials-toolbar #23005 +/- ##
====================================================================
- Coverage 56.06% 56.05% -0.02%
====================================================================
Files 4467 4467
Lines 143101 143072 -29
Branches 22603 22589 -14
====================================================================
- Hits 80234 80202 -32
- Misses 57117 57130 +13
+ Partials 5750 5740 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design review 2026-09-04: "the daemon tab should be access connectors". The SDK already agrees, re-exporting
AccessConnectorStatus.The harvested frames call it "Rotation connectors"; the review is later and direct, so it wins. Route renamed too, safe because the feature is unreleased and flag gated. Files, classes and DB tables still say daemon deliberately: a mechanical identifier rename would bury the reviewable part of this diff.