Skip to content

fix(pam): cap the access requests search width and move its filters onto bit-filter-menu - #23003

Draft
maxkpower wants to merge 3 commits into
pam/uatfrom
pam/requests-toolbar-filter-menu
Draft

fix(pam): cap the access requests search width and move its filters onto bit-filter-menu#23003
maxkpower wants to merge 3 commits into
pam/uatfrom
pam/requests-toolbar-filter-menu

Conversation

@maxkpower

Copy link
Copy Markdown
Contributor

Design review 2026-09-04: the search field is too wide, and bit-filter-menu is wanted everywhere bit-chip-filter is used.

bit-search sets no host display class, so as a block child it is an inline box and max-width does not apply; the cap only works once it is a flex item. After this, no bit-chip-filter remains under app/pam/.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.05%. Comparing base (e7321e3) to head (791e6cd).
⚠️ Report is 288 commits behind head on pam/uat.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ense/bit-web/src/app/pam/testing/story-fixtures.ts 0.00% 2 Missing ⚠️
...p/pam/access-requests/my-requests-tab.component.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           pam/uat   #23003      +/-   ##
===========================================
+ Coverage    55.74%   56.05%   +0.30%     
===========================================
  Files         4438     4467      +29     
  Lines       141404   143051    +1647     
  Branches     22371    22594     +223     
===========================================
+ Hits         78824    80182    +1358     
- Misses       56914    57118     +204     
- Partials      5666     5751      +85     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant