Skip to content

fix(pam): keep the access-rule edit breadcrumb trail on one line - #23001

Draft
maxkpower wants to merge 3 commits into
pam/access-rule-collections-governed-filterfrom
pam/access-rule-breadcrumb-layout
Draft

fix(pam): keep the access-rule edit breadcrumb trail on one line#23001
maxkpower wants to merge 3 commits into
pam/access-rule-collections-governed-filterfrom
pam/access-rule-breadcrumb-layout

Conversation

@maxkpower

Copy link
Copy Markdown
Contributor

Design review 2026-09-04: "the breadcrumbs are broken". bit-breadcrumbs sets tw-w-full on its host, so the sibling crumb was pushed to the far edge and squeezed to its min-content width.

The last crumb is deliberately not a bit-breadcrumb: under VFO1 an active crumb is promoted to the page <h1>, which would replace the rule name.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.04%. Comparing base (1b4ff17) to head (254fb85).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ense/bit-web/src/app/pam/testing/story-fixtures.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                               @@
##           pam/access-rule-collections-governed-filter   #23001      +/-   ##
===============================================================================
- Coverage                                        56.05%   56.04%   -0.02%     
===============================================================================
  Files                                             4467     4467              
  Lines                                           143064   143036      -28     
  Branches                                         22594    22580      -14     
===============================================================================
- Hits                                             80201    80162      -39     
- Misses                                           57113    57132      +19     
+ Partials                                          5750     5742       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant