fix(pam): exclude already-governed collections from the access-rule collections picker - #23000
Draft
maxkpower wants to merge 3 commits into
Draft
fix(pam): exclude already-governed collections from the access-rule collections picker#23000maxkpower wants to merge 3 commits into
maxkpower wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pam/uat #23000 +/- ##
===========================================
+ Coverage 55.74% 56.05% +0.31%
===========================================
Files 4438 4467 +29
Lines 141404 143064 +1660
Branches 22371 22594 +223
===========================================
+ Hits 78824 80201 +1377
- Misses 56914 57113 +199
- Partials 5666 5750 +84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design review 2026-09-04: the save error names no collection, so an admin cannot tell which one conflicts. The server sends prose with no ids (
AccessRuleWriteValidator), so prevention is the only fix: collections governed by another rule are no longer offered.Note the conflict is
Collection.AccessRuleId != existingRuleId, so a disabled rule still governs. The server error stays as the backstop, since the read is cached for 30s.