Skip to content

Bug: Fix CipherType crash#6922

Merged
david-livefront merged 1 commit into
mainfrom
fix-cipher-type-crash
May 14, 2026
Merged

Bug: Fix CipherType crash#6922
david-livefront merged 1 commit into
mainfrom
fix-cipher-type-crash

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR fixes a crash if the server sends a Passport of License CipherType to the application.

@david-livefront david-livefront requested a review from a team as a code owner May 14, 2026 18:47
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug labels May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.88%. Comparing base (f002c2c) to head (7f96806).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6922      +/-   ##
==========================================
- Coverage   86.17%   85.88%   -0.30%     
==========================================
  Files         854      899      +45     
  Lines       61583    63319    +1736     
  Branches     8982     9024      +42     
==========================================
+ Hits        53071    54382    +1311     
- Misses       5430     5844     +414     
- Partials     3082     3093      +11     
Flag Coverage Δ
app-data 16.98% <100.00%> (-0.34%) ⬇️
app-ui-auth-tools 19.56% <0.00%> (-0.01%) ⬇️
app-ui-platform 16.05% <0.00%> (+0.55%) ⬆️
app-ui-vault 27.91% <0.00%> (+0.56%) ⬆️
authenticator 6.38% <0.00%> (-0.05%) ⬇️
lib-core-network-bridge 4.14% <0.00%> (+0.01%) ⬆️
lib-data-ui 1.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR fixes a crash that occurred when the server returned a DRIVERS_LICENSE or PASSPORT CipherType by mapping them to the corresponding SDK CipherType.DRIVERS_LICENSE and CipherType.PASSPORT values instead of throwing IllegalArgumentException. The downstream UI mapping (CipherTypeExtensions.toVaultItemCipherType) and VaultItemCipherType enum already support these two types, so the change is consistent end-to-end. Test coverage was updated to assert the new mapping behavior rather than the previously expected exception.

Code Review Details

No findings.

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 92845c6 May 14, 2026
28 checks passed
@david-livefront david-livefront deleted the fix-cipher-type-crash branch May 14, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants