Add Note service for note.* v3 support (#515)#524
Open
fatestr1ngs wants to merge 2 commits into
Open
Conversation
Implements all 25 note.* methods (Knowledge Base 2.0): Collection, Document (incl. tree and search), and File, with typed select builders and cursor pagination for note.collection.list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
note.*v3 scope (Knowledge Base 2.0) — all 25 methods across three services:Collection(note.collection.*, 8 methods):add,archive,delete,fieldGet,fieldList,get,list,update.list()uses cursor-based pagination via typedCollectionListPagination/CollectionListCursorvalue objects (modeled on the existingMain\Service\EventLogTailCursoridiom), since the server returns a ready-madenextCursorobject.Document(note.document.*, 13 methods): CRUD + archive, plusnote.document.tree.*andnote.document.search.*folded into the same service class.File(note.file.*, 4 methods): upload (base64-encoded content) and retrieval.Note: while implementing, live verification against a real portal showed that every
*.field.listresponse wraps its array inresult.items(matching every other list endpoint), even though the OpenAPI schema describesresultitself as a flat array. All five*FieldsResultclasses were fixed and covered by integration tests that assert non-empty field lists.Test plan
make lint-cs-fixer— passedmake lint-deptrac— passed (0 violations)make test-unit— passed (1013/1013, no regressions)make test-integration-note-collection— passed (11/11, live portal)make test-integration-note-document— passed (21/21, live portal)make test-integration-note-file— passed (6/6, live portal)make lint-phpstan/make lint-rector— passedCloses #515