Handle tss txp deletion; Add cli session restoration; Bug fixes#4206
Open
kajoseph wants to merge 1 commit into
Open
Handle tss txp deletion; Add cli session restoration; Bug fixes#4206kajoseph wants to merge 1 commit into
kajoseph wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If walletA is in the process of signing a txp and walletB deletes the txp, then walletA will be spinning indefinitely. This PR deletes corresponding TSS signing sessions when deleting a txp. This will cause walletA's session to error with a "Session not found" error, leaving it up to the client to handle appropriately (as seen in CLI).
Furthermore, this PR adds support for TSS session restoration in case a session is interrupted.
Even furthermore, this fixes a couple of CLI bugs.
Changelog
Testing Notes
Add any helpful notes for reviewers to test your code here.
Checklist