fix(p2ms): isAcceptableSignature always returned true due to operator precedence#2332
Open
Grizouforever wants to merge 1 commit intobitcoinjs:masterfrom
Open
Conversation
… precedence The expression `(opts!.allowIncomplete && ...) !== undefined` always evaluates to `true` because any boolean value (including `false`) is not `undefined`. This caused `isAcceptableSignature` to accept any input as a valid signature, bypassing P2MS signature validation entirely. Fix by wrapping the expression with `!!` to coerce it to a proper boolean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
ts_src/payments/p2ms.ts, theisAcceptableSignaturefunction contains a logic bug caused by JS operator precedence:The
!== undefinedcheck is applied to the result of the&&expression, which is always a boolean (trueorfalse). Since neithertruenorfalseisundefined, this condition always evaluates totrue— meaningisAcceptableSignatureaccepted any input as a valid signature, completely bypassing P2MS signature validation.Fix: Coerce the expression to a proper boolean with
!!:Impact
Without this fix, P2MS inputs with invalid/garbage signatures pass validation silently. The function was intended to only allow
OP_0placeholders whenallowIncompleteis set.Tests
All 2660 existing tests pass, including the p2ms-specific tests that assert
"throws Input has invalid signature(s)". No test changes were needed — the existing fixtures already encode the correct expected behavior.