fix(keys): return secret bytes for single descriptor keys#1027
Draft
reez wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DescriptorSecretKey::from_string()accepts both extended private keys and single private keys encoded as WIF.secret_bytes()only handled the extended private key case and treated single keys as unreachable, which caused a panic when called with a valid WIF-derivedDescriptorSecretKey.This updates
secret_bytes()to return bytes for single private keys directly, while preserving existing behavior for extended private keys. It also handles multipath extended private keys by returning the underlying xprv secret bytes.Documentation
bdk_walletbdk_wallet::keysdocumentsDescriptorSecretKeyas either a single private key or an xprv.bitcoinbitcoin::PrivateKeycovers WIF parsing and the underlying private key representation used for single-key bytes.Other:
miniscript::descriptor::DescriptorSecretKeyis the upstream enum withSingle,XPrv, andMultiXPrvvariants.secp256k1::SecretKey::secret_bytesis the upstream byte extraction method used for the returned secret bytes.Changelog
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingchangelog:*labelNew Features:
Bugfixes: