FEAT: add precessing spin transformation - #1104
Open
ColmTalbot wants to merge 11 commits into
Open
Conversation
GregoryAshton
left a comment
GregoryAshton
left a comment
Collaborator
There was a problem hiding this comment.
Broadly looks good to me - albeit the checks are failing
| - spin_2x, spin_2y, spin_2z: Components of spin 2 | ||
| """ | ||
|
|
||
| xp = array_module(theta_jn) |
Collaborator
There was a problem hiding this comment.
Does array_module here just take theta_jn to figure out the array type?
Collaborator
Author
There was a problem hiding this comment.
This was using an outdated version. I updated it to use the xp_wrap decorator, which will look at all of the input arguments.
ColmTalbot
force-pushed
the
precessing-spin-transform
branch
2 times, most recently
from
July 6, 2026 17:39
7a82a82 to
6b7f838
Compare
Updated tolerance for assert_allclose due to precision loss in different array backends.
Added error handling for ZeroDivisionError when calculating spins.
ColmTalbot
force-pushed
the
precessing-spin-transform
branch
from
August 11, 2026 18:11
1c0807a to
34fcfc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #1044 that includes the backend changes rather than attempting to rebase.