Skip to content

refactor(web): centralize app store connection lookup - #7

Merged
thomasorgeval merged 1 commit into
mainfrom
small-refactor/apps-store-connection-lookup
Jun 21, 2026
Merged

refactor(web): centralize app store connection lookup#7
thomasorgeval merged 1 commit into
mainfrom
small-refactor/apps-store-connection-lookup

Conversation

@thomasorgeval

Copy link
Copy Markdown
Member

Summary

  • Centralized the active Store Connection lookup used by the apps page for Apple App Store and Google Play actions.
  • Behavior is intended to be unchanged; the existing protected template-facing methods now delegate to shared helpers.

Expected impact

  • Reduces duplicated provider/status/credential predicates across configured-state, sync-loading, and sync-result helpers.
  • Makes future provider handling changes safer by keeping the active Store Connection criteria in one place.

Verification

  • pnpm nx typecheck web --tui=false
  • pnpm nx lint web --tui=false
  • pnpm exec biome format --write apps/web/src/app/pages/apps/apps.page.ts
  • git diff --check

@thomasorgeval
thomasorgeval marked this pull request as ready for review June 21, 2026 11:10
@thomasorgeval
thomasorgeval merged commit 95916f4 into main Jun 21, 2026
1 check passed
@thomasorgeval
thomasorgeval deleted the small-refactor/apps-store-connection-lookup branch June 21, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant