Fix Docker dashboard embedding - #17
Merged
Merged
Conversation
biancarosa
marked this pull request as ready for review
May 19, 2026 23:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embed_dashboard./api/proxyand/api/admin/*routes, withNETKIT_DASHBOARD_BASE_PATH/--dashboard-base-pathsupport for path-based reverse proxies such as/netkit.Root Cause
The published Docker image could run a binary that served the fallback dashboard, and the frontend assumed browser-visible
localhost:8080/8081API URLs. That broke embedded Docker deployments and path-based reverse proxy setups.Validation
go test ./...cd dashboard && npm run build:staticmake test-docker-dashboardNETKIT_DASHBOARD_BASE_PATH=/netkit NETKIT_DOCKER_IMAGE=netkit:dashboard-validation-netkit NETKIT_DOCKER_DASHBOARD_PORT=13001 NETKIT_DOCKER_PROXY_PORT=18082 NETKIT_DOCKER_ADMIN_PORT=18083 make test-docker-dashboard