Skip to content

Fix e2e test #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biancarosa merged 1 commit into from
Oct 27, 2025
Merged

Fix e2e test #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Download Go modules
run: go mod download

- name: Build fetchr binary
- name: Build netkit binary
run: make build

- name: Run Go end-to-end tests
Expand Down
9 changes: 7 additions & 2 deletions test/e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,18 @@ type netkitCmd struct {

// startProxyServer starts the netkit proxy server with the given arguments
func startProxyServer(t *testing.T, args ...string) *netkitCmd {
// Build binary path - we assume the binary is in the root directory
binaryPath := filepath.Join("..", "..", "netkit")
// Build binary path - we assume the binary is in the bin directory
binaryPath := filepath.Join("..", "..", "bin", "netkit")

// Check if binary exists
if _, err := os.Stat(binaryPath); os.IsNotExist(err) {
// Try to build it
t.Log("Netkit binary not found, building it")
// Ensure bin directory exists
binDir := filepath.Join("..", "..", "bin")
if err := os.MkdirAll(binDir, 0755); err != nil {
t.Fatalf("Failed to create bin directory: %v", err)
}
buildCmd := exec.Command("go", "build", "-o", binaryPath, "../../cmd/netkit")
if err := buildCmd.Run(); err != nil {
t.Fatalf("Failed to build netkit binary: %v", err)
Expand Down