Cleanups

common/include/guiddef.h

@@ -90,7 +90,9 @@ typedef struct _GUID {
     EXTERN_C const GUID FAR name
 #endif // INITGUID
 
+#if _MSC_VER < 1900
 #define DEFINE_OLEGUID(name, l, w1, w2) DEFINE_GUID(name, l, w1, w2, 0xC0,0,0,0,0,0,0,0x46)
+#endif
 
 #ifndef _GUIDDEF_H_
 #define _GUIDDEF_H_

image/decode/segdec.c

@@ -63,7 +63,9 @@ static U32 _FORCEINLINE _load4(void* pv)
     v |= ((U32)((U16 *) pv)[1]) << 16;
     return _byteswap_ulong(v);
 #else // _M_IA64
-    return _byteswap_ulong(*(U32*)pv);
+    U32 v;
+    memcpy(&v, pv, sizeof(U32));
+    return _byteswap_ulong(v);
 #endif // _M_IA64
 #endif // _BIG__ENDIAN_
 }
@@ -959,7 +961,7 @@ Int DecodeMacroblockLowpass (CWMImageStrCodec * pSC, CCodingContext *pContext,
                         pCoeffs[k] += getBits (pIO, iModelBits);
                     }
                     else if (pCoeffs[k] < 0) {
-                        pCoeffs[k] <<= iModelBits;
+                        pCoeffs[k] = (int) (((unsigned) pCoeffs[k]) << iModelBits);
                         pCoeffs[k] -= getBits (pIO, iModelBits);
                     }
 #endif // WIN32

image/encode/strenc.c

@@ -482,8 +482,10 @@ Int StrIOEncInit(CWMImageStrCodec* pSC)
                 pSC->ppTempFile[i] = (char *)malloc(FILENAME_MAX * sizeof(char));
                 if(pSC->ppTempFile[i] == NULL) return ICERR_ERROR;
 
-                if ((pFilename = tmpnam(NULL)) == NULL)
+                char tmpnambuf[] = {'f', 'i', 'l', 'e', 'X', 'X', 'X', 'X', 'X', 'X', '\0'};
+                if (mkstemp(tmpnambuf) == -1)
                     return ICERR_ERROR;                
+                pFilename = tmpnambuf;
                 strcpy(pSC->ppTempFile[i], pFilename);
 #endif
                 if(CreateWS_File(pSC->ppWStream + i, pFilename, "w+b") != ICERR_OK) return ICERR_ERROR;                

image/sys/adapthuff.c

@@ -28,6 +28,8 @@
 
 #include "strcodec.h"
 
+#include <limits.h>
+
 #ifdef MEM_TRACE
 #define TRACE_MALLOC    1
 #define TRACE_NEW       0
@@ -459,7 +461,7 @@ Void AdaptDiscriminant (CAdaptiveHuffman *pAdHuff)
     assert (t < gMaxTables[iSym]);
 
     //pAdHuff->m_iDiscriminant >>= 1;
-    pAdHuff->m_iLowerBound = (t == 0) ? (-1 << 31) : -THRESHOLD;
+    pAdHuff->m_iLowerBound = (t == 0) ? INT_MIN : -THRESHOLD;
     pAdHuff->m_iUpperBound = (t == gMaxTables[iSym] - 1) ? (1 << 30) : THRESHOLD;
 
     switch (iSym) {

image/sys/ansi.h

@@ -27,6 +27,8 @@
 //*@@@---@@@@******************************************************************
 #pragma once
 
+#include <stdint.h>
+
 //================================
 // bitio functions
 //================================
@@ -42,20 +44,5 @@
 //================================
 // common defines
 //================================
-#define FORCE_INLINE
-#define CDECL
-#if __LP64__
-#define UINTPTR_T unsigned long long
-#define INTPTR_T long long
-#else
-#define UINTPTR_T unsigned int
-#define INTPTR_T int
-#endif
-
-
-//================================
-// quantization optimization
-//================================
-//#define RECIP_QUANT_OPT
-
-
+#define UINTPTR_T uintptr_t
+#define INTPTR_T intptr_t

image/sys/image.c

@@ -27,7 +27,6 @@
 //*@@@---@@@@******************************************************************
 
 #include "strcodec.h"
-// #include "xplatform_image.h"
 
 #ifdef MEM_TRACE
 #define TRACE_MALLOC    1

image/sys/strcodec.c

@@ -671,6 +671,7 @@ ERR detach_SB(SimpleBitIO* pSB)
 #ifdef _BIG__ENDIAN_
 #define _byteswap_ulong(x)  (x)
 #else // _BIG__ENDIAN_
+#if _MSC_VER < 1924
 U32 _byteswap_ulong(U32 bits)
 {
     U32 r = (bits & 0xffu) << 24;
@@ -680,6 +681,7 @@ U32 _byteswap_ulong(U32 bits)
 
     return r;
 }
+#endif // _MSC_VER
 #endif // _BIG__ENDIAN_
 #endif
 
@@ -694,7 +696,9 @@ U32 load4BE(void* pv)
     v |= ((U32)((U16 *) pv)[1]) << 16;
     return _byteswap_ulong(v);
 #else // _M_IA64
-    return _byteswap_ulong(*(U32*)pv);
+    U32 v;
+    memcpy(&v, pv, sizeof(U32));
+    return _byteswap_ulong(v);
 #endif // _M_IA64
 #endif // _BIG__ENDIAN_
 }

image/sys/strcodec.h

@@ -31,7 +31,6 @@
 
 #include "windowsmediaphoto.h"
 #include "common.h"
-// #include "xplatform_image.h"
 
 // added for Xcode PK universal binary
 #ifdef __ppc__
@@ -64,7 +63,7 @@
 
 #ifndef UNREFERENCED_PARAMETER
 #define UNREFERENCED_PARAMETER(P) { (P) = (P); }
-#endif UNREFERENCED_PARAMETER
+#endif // UNREFERENCED_PARAMETER
 
 #ifdef UNDER_CE
 #define PLATFORM_WCE

image/x86/x86.h

@@ -50,9 +50,3 @@
 #define INTPTR_T intptr_t
 
 
-//================================
-// quantization optimization
-//================================
-#define RECIP_QUANT_OPT
-
-

jxrgluelib/JXRGlueJxr.c

@@ -27,6 +27,7 @@
 //
 //*@@@---@@@@******************************************************************
 #include <limits.h>
+#include <wchar.h>
 #include <JXRGlue.h>
 
 

jxrtestlib/JXRTestHdr.c

@@ -27,7 +27,7 @@
 //*@@@---@@@@******************************************************************
 #ifndef ANSI
 #define _CRT_SECURE_NO_WARNINGS
-#endif ANSI
+#endif // ANSI
 
 #include <stdlib.h>
 #include <string.h>

jxrtestlib/JXRTestPnm.c

@@ -27,7 +27,7 @@
 //*@@@---@@@@******************************************************************
 #ifndef ANSI
 #define _CRT_SECURE_NO_WARNINGS
-#endif ANSI
+#endif // ANSI
 
 #include <stdlib.h>
 

jxrtestlib/JXRTestYUV.c

@@ -120,6 +120,9 @@ ERR PKImageEncode_WritePixels_IYUV(
 
     if(pY == NULL || pU == NULL || pV == NULL)
     {
+        free(pY);
+        free(pU);
+        free(pV);
         return ICERR_ERROR;
     }
 
@@ -198,6 +201,9 @@ ERR PKImageEncode_WritePixels_YUV422(
 
     if(pY == NULL || pU == NULL || pV == NULL)
     {
+        free(pY);
+        free(pU);
+        free(pV);
         return ICERR_ERROR;
     }
 //YYUV
@@ -273,6 +279,9 @@ ERR PKImageEncode_WritePixels_YUV444(
 
     if(pY == NULL || pU == NULL || pV == NULL)
     {
+        free(pY);
+        free(pU);
+        free(pV);
         return ICERR_ERROR;
     }
 
@@ -491,6 +500,9 @@ ERR PKImageDecode_Copy_IYUV(
 
     if(pY == NULL || pU == NULL || pV == NULL)
     {
+        free(pY);
+        free(pU);
+        free(pV);
         return ICERR_ERROR;
     }
 
@@ -564,6 +576,9 @@ ERR PKImageDecode_Copy_YUV422(
 
     if(pY == NULL || pU == NULL || pV == NULL)
     {
+        free(pY);
+        free(pU);
+        free(pV);
         return ICERR_ERROR;
     }
 
@@ -635,6 +650,9 @@ ERR PKImageDecode_Copy_YUV444(
 
     if(pY == NULL || pU == NULL || pV == NULL)
     {
+        free(pY);
+        free(pU);
+        free(pV);
         return ICERR_ERROR;
     }