Only re-allocate modified meshes with differing sizes/layouts#24326
Draft
Aceeri wants to merge 2 commits into
Draft
Only re-allocate modified meshes with differing sizes/layouts#24326Aceeri wants to merge 2 commits into
Aceeri wants to merge 2 commits into
Conversation
Aceeri
force-pushed
the
mesh-allocator-reuse-same-size
branch
from
0251c3b to
be3afdc
Compare
Aceeri
added
A-Rendering
Aceeri
added
the
S-Needs-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
There isn't currently a way to not re-allocate meshes/re-use meshes that you want to update. In my case a solid 40-90% of my runtime ends up dominated by allocate_and_free_meshes as I'm modifying terrain/voxel meshes often.
Solution
Only free & allocate if the attribute size/layout differs from the previous upload. With this you can create statically sized meshes that you can modify/reuse :)
Testing
TBD
Showcase