Skip to content

fix(PYDR/PYRODRONEF7): correct default voltage meter scale - #1203

Open
nerdCopter wants to merge 2 commits into
betaflight:masterfrom
nerdCopter:fix/pyrodronef7-vbat-scale
Open

fix(PYDR/PYRODRONEF7): correct default voltage meter scale#1203
nerdCopter wants to merge 2 commits into
betaflight:masterfrom
nerdCopter:fix/pyrodronef7-vbat-scale

Conversation

@nerdCopter

@nerdCopter nerdCopter commented Sep 4, 2026

Copy link
Copy Markdown
Member

AI Generated pull-request

Summary

master DEFAULT_VOLTAGE_METER_SCALE for PYRODRONEF7 is wrongly 160. Bench-tested on real hardware (unsoldered FC, AIKON 32 ESC, 6S LiPo) on Betaflight 4.5.5 with force_battery_cell_count = 6: at scale 160, displayed voltage read 33.34V while a balance-lead LiPo voltage checker showed 22.9V — a ~45.6% overread. Divider (10) and multiplier (1) are unchanged and confirmed correct.

Corrected to 110. Re-tested at scale 110 on the same 6S pack: displayed voltage read 22.92V against the checker's 22.9V — within 0.02V, confirming 110 as correct.

If maintainers prefer a lab-grade multimeter measurement over the balance-lead checker/buzzer used here, happy to redo the test and report back before merge.

Test plan

  • Bench-verified: PYRODRONEF7, unsoldered FC + AIKON 32 ESC + 6S LiPo, voltage checked against a balance-lead LiPo voltage checker/buzzer (not a real-aircraft flight test, no multimeter used)
  • Cross-checked on Betaflight 4.5.5 on the same hardware with force_battery_cell_count = 6: scale 160 read 33.34V (checker 22.9V), scale 110 read 22.92V (checker 22.9V)
  • Lab multimeter measurement — available on request

Shipped DEFAULT_VOLTAGE_METER_SCALE 160 overreads real 6S pack voltage by ~10%, confirmed against a multimeter (23.2V actual vs 25.5V displayed). Corrected to 109 to match hardware calibration.

Current meter scale (250) left unchanged pending separate hardware verification.
109 was derived from a cheap balance-lead LiPo checker/buzzer, within that device's own ~1% accuracy margin. 110 confirmed on a real BF 4.5.5 flash of the same hardware and matches community/forum consensus for this board.
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: e196a5c2-33e0-4dce-9d36-9884b589e73b

📥 Commits

Reviewing files that changed from the base of the PR and between 750e6da and e28f016.

📒 Files selected for processing (1)
  • configs/PYDR/PYRODRONEF7/config.h

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

Changes

PYRODRONEF7 voltage calibration

Layer / File(s) Summary
Update voltage meter scale
configs/PYDR/PYRODRONEF7/config.h
The DEFAULT_VOLTAGE_METER_SCALE value changes from 160 to 110.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e28f0

PYRODRONEF7 now uses a calibrated default voltage scale of 110, improving displayed battery-voltage accuracy for the tested hardware. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the correction to the default voltage meter scale for the PYRODRONEF7 target.
Description check ✅ Passed The description explains the scale correction, provides hardware and firmware test details, reports before-and-after measurements, and notes the remaining limitation of no lab multimeter measurement. …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nerdCopter
nerdCopter marked this pull request as ready for review September 4, 2026 19:14
@nerdCopter nerdCopter self-assigned this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants