Fix for RASPBERRY_PI_UAVFC - swap pins for BEC 5V, 9V enable - #1202
Fix for RASPBERRY_PI_UAVFC - swap pins for BEC 5V, 9V enable#1202mjs1441 wants to merge 1 commit into
Conversation
The GPIOs for PICO_BEC_5V_ENABLE_PIN and PICO_BEC_9V_ENABLE_PIN were the wrong way round. Swapping makes no functional difference, as each is separately enabled in the code according to the GPIO number, but this clarifies in case a user wishes to override with PINIO or similar.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe Raspberry Pi UAVFC configuration documents active-high BEC enable behavior and swaps the 5V and 9V BEC enable pin assignments. ChangesRaspberry Pi BEC Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The board configuration now maps the 5V and 9V BEC enable pins as intended and documents active-high enable behavior. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fix for RASPBERRY_PI_UAVFC - swap pins for BEC 5V, 9V enable
The GPIOs for PICO_BEC_5V_ENABLE_PIN and PICO_BEC_9V_ENABLE_PIN were the wrong way round.
Swapping makes no functional difference, as each is separately enabled in the code according
to the GPIO number, but this clarifies in case a user wishes to override with PINIO or similar.
Summary by CodeRabbit