Skip to content

Fix for RASPBERRY_PI_UAVFC - swap pins for BEC 5V, 9V enable - #1202

Open
mjs1441 wants to merge 1 commit into
betaflight:masterfrom
mjs1441:pico_raspberry_pi_uavfc_becpins
Open

Fix for RASPBERRY_PI_UAVFC - swap pins for BEC 5V, 9V enable#1202
mjs1441 wants to merge 1 commit into
betaflight:masterfrom
mjs1441:pico_raspberry_pi_uavfc_becpins

Conversation

@mjs1441

@mjs1441 mjs1441 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fix for RASPBERRY_PI_UAVFC - swap pins for BEC 5V, 9V enable

The GPIOs for PICO_BEC_5V_ENABLE_PIN and PICO_BEC_9V_ENABLE_PIN were the wrong way round.
Swapping makes no functional difference, as each is separately enabled in the code according
to the GPIO number, but this clarifies in case a user wishes to override with PINIO or similar.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the hardware control pin assignments for the 5V and 9V BEC outputs.
    • Clarified that a high signal enables the BEC output.

The GPIOs for PICO_BEC_5V_ENABLE_PIN and PICO_BEC_9V_ENABLE_PIN were the wrong way round.
Swapping makes no functional difference, as each is separately enabled in the code according
to the GPIO number, but this clarifies in case a user wishes to override with PINIO or similar.
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: d9cec706-ffde-468c-92b8-b7d6e022d6f9

📥 Commits

Reviewing files that changed from the base of the PR and between 750e6da and be86123.

📒 Files selected for processing (1)
  • configs/RASP/RASPBERRY_PI_UAVFC/config.h

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The Raspberry Pi UAVFC configuration documents active-high BEC enable behavior and swaps the 5V and 9V BEC enable pin assignments.

Changes

Raspberry Pi BEC Configuration

Layer / File(s) Summary
BEC pin assignments and polarity
configs/RASP/RASPBERRY_PI_UAVFC/config.h
The configuration documents that high enables the BEC and assigns PA19 to the 5V BEC and PA18 to the 9V BEC.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to be861

The board configuration now maps the 5V and 9V BEC enable pins as intended and documents active-high enable behavior. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the GPIO swap and its effect, but it does not include the required review, compliance, housekeeping, or checklist information from the repository template. Add the required template sections. State the status of schematics review, hardware sample testing, guideline compliance, connector standards, flight testing, and comment or issue resolution. Include any relevant housekeeping details.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the RASPBERRY_PI_UAVFC target and the main change: swapping the BEC 5V and 9V enable pins.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants