Add UAVDF722BT - #1180
Open
haslinghuis wants to merge 8 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughChangesUAVF722BTV5 target
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
osirisinferi
requested changes
Aug 7, 2026
haslinghuis
added a commit
to haslinghuis/schema-convert
that referenced
this pull request
Aug 7, 2026
Both found reviewing betaflight/config#1180, which was generated by this tool - so what it missed, the tool missed. CAM_CTRL was classified as nothing, so that board lost camera control entirely: the net was read, matched no rule, and the feature never appeared. The pattern took CONTROL and CONTROLL but not CTRL, and CAM but not CAMERA before either. PB8 there carries TIM4_CH3, so it was always a valid camera control pin. DEFAULT_BLACKBOX_DEVICE = BLACKBOX_DEVICE_FLASH required only USE_FLASH, which says the driver is compiled in and nothing about the chip being reachable. That PR ships FLASH_CS_PIN, USE_FLASH and BLACKBOX_DEVICE_FLASH with no instance, so pg/flash.c leaves it NULL and logging is dead on arrival - exactly the 4.10 case the check exists to catch, and it did not. It now also requires one of FLASH_SPI_INSTANCE, FLASH_QUADSPI_INSTANCE or FLASH_OCTOSPI_INSTANCE; a needs entry may be a tuple meaning any one of them. Corpus: 0 defines change - both are spellings and a check, and no corpus board uses CAM_CTRL. Measured against a baseline regenerated with the change stashed, because the artifact I first compared against had been built from a different board list and showed a 70-define delta that had nothing to do with either edit. The strengthened check reports what the weak one could not: 44 of 104 boards emit DEFAULT_BLACKBOX_DEVICE with no way to reach the device. Left as a warning for now rather than suppressing the define, since that is a behaviour change on 42% of the corpus and wants deciding on its own. Goldens: two boards, one warning each.
haslinghuis
added a commit
to haslinghuis/schema-convert
that referenced
this pull request
Aug 7, 2026
…, and PINIO boxes take their name from the net Both from reviewing betaflight/config#1180, and the first one disagrees with the review. The reviewer added a TIMER_PIN_MAP row for BEEPER_PIN. Checked before copying it: beeperInit() reads beeperFrequency from BEEPER_PWM_HZ, which defaults to 0, and only calls beeperPwmInit() when it is non-zero. An active buzzer - what almost every board has - is plain GPIO and never allocates the timer, so the row does nothing. It is a widespread copy-paste: 25 of 619 shipped targets carry a beeper row and exactly one of them sets BEEPER_PWM_HZ. So no row is emitted; instead inert_beeper_timer_row() says so when one is present without the frequency, since a reviewer adding it expects an effect and a passive buzzer needs both halves. The beeper is now a rate class, which is the half of the review that was right. Its choice of occurrence 2 for camera control - TIM10_CH1 rather than the tool's TIM4_CH3 - avoids sharing TIM4 with a beeper on CH4, and the rate check could not see that because the beeper was not a class. It can now. BOX_USERn_NAME is taken from the net. Half the corpus's PINIO nets say what the switch does - VTX-SWITCH, CAM_SW, BEC12V_EN, 9V_EN - which is a better button label than "PINIO1"; the other half say nothing and keep the positional fallback. Tidied, not translated: the old code turned anything containing VTX into "VTX PWR", which claims the switch controls power where the sheet said only "switch". Capped at 15, the longest any shipped target uses. Corpus: defines unchanged, no board's define set changed - box names are values. Goldens: three boards, digests only, "VTX PWR" -> "VTX SW" and "PINIO2" -> "CAM SW".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
osirisinferi
requested changes
Aug 7, 2026
osirisinferi
left a comment
osirisinferi
left a comment
Member
There was a problem hiding this comment.
Sorry, missed this earlier.
haslinghuis
force-pushed
the
add-UAVDF722BT
branch
from
August 8, 2026 06:34
6433162 to
67625fb
Compare
Contributor
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@configs/UAVD/UAVDF722BT/config.h`:
- Around line 22-33: Remove the generator-operator text from the header comment,
specifically the “No REFERENCE directive” paragraph and its follow-up
instruction. In the target configuration, replace the unregistered UAVD
manufacturer usage with an existing registered MANUFACTURER_ID, or add the UAVD
entry to Manufacturers.md before assigning it.
- Around line 81-87: Confirm the flash chip’s SPI bus from the schematic, then
add the missing FLASH_SPI_INSTANCE definition near FLASH_CS_PIN, using SPI3 if
that is the connected bus. Ensure the existing USE_FLASH and blackbox flash
configuration routes the flash device through that instance without changing the
gyro or MAX7456 assignments.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b36c2b63-cdd6-42d6-89a1-ba2610358969
📒 Files selected for processing (1)
configs/UAVD/UAVDF722BT/config.h
Comment on lines
+22
to
+33
| /* | ||
| Generated from SCH_原理图_5.0.5.pdf | ||
| Schematic sha256: 03a9f5864dc03d59e265cfc4107a88e9205a9510b7e9c37295faf167de67a8c8 | ||
| MCU symbol: 64 pins on page 3 of 8 | ||
| Converted: 2026-08-08 | ||
| Pin tables validated against Betaflight c18421eb5 (branch master, seeded 2026-08-04) | ||
| Manufacturer: UAVD - NOT REGISTERED in betaflight/config Manufacturers.md @ 18ffb2a74 (2026-07-23) | ||
|
|
||
| No REFERENCE directive: this target has not been reviewed by | ||
| the Betaflight team. They issue that value; it cannot be | ||
| computed here. Re-run with --reference once it is provided. | ||
| */ |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the generator boilerplate and register the manufacturer ID.
Lines 30-32 address the generator operator, not readers of this repository. Remove them.
The comment also states that UAVD is not registered in Manufacturers.md. A new MANUFACTURER_ID must be registered before this target can be merged. Submit the manufacturer entry, or reuse an existing registered ID.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@configs/UAVD/UAVDF722BT/config.h` around lines 22 - 33, Remove the
generator-operator text from the header comment, specifically the “No REFERENCE
directive” paragraph and its follow-up instruction. In the target configuration,
replace the unregistered UAVD manufacturer usage with an existing registered
MANUFACTURER_ID, or add the UAVD entry to Manufacturers.md before assigning it.
Member
Author
There was a problem hiding this comment.
@coderabbitai this will be replaced once we have a sha. There is already a PR for adding the manufacturer.
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
gh pr list \
--repo betaflight/config \
--state open \
--search 'UAVD in:title,body' \
--limit 20 \
--json number,title,url,body,filesLength of output: 317
🏁 Script executed:
#!/bin/bash
set -euo pipefail
gh pr list \
--repo betaflight/config \
--state open \
--search 'manufacturer in:title,body' \
--limit 50 \
--json number,title,url,files \
--jq '.[] | {
number,
title,
url,
matching_files: [.files[]?.path | select(test("Manufacturers\\.md$"))]
} | select(.matching_files | length > 0)'Length of output: 2882
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- Target manufacturer declaration ---'
rg -n -C 2 '^\s*`#define`\s+MANUFACTURER_ID\b' configs/UAVD/UAVDF722BT/config.h
printf '%s\n' '--- PR `#1179` Manufacturers.md patch ---'
gh api \
repos/betaflight/config/pulls/1179/files \
--paginate \
--jq '.[] | select(.filename == "Manufacturers.md") | .patch'Length of output: 1081
@haslinghuis, confirmed. Pull request #1179 registers the exact UAVD MANUFACTURER_ID used by this target.
The manufacturer registration does not require a separate change in this PR, provided #1179 merges before this target. I also understand that the temporary header paragraph will be replaced when the reference SHA is available.
You are interacting with an AI system.
osirisinferi
requested changes
Aug 8, 2026
Co-authored-by: Osiris Inferi <github@flut.nl.eu.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (✓/✕, or y/n)
Summary by CodeRabbit