Add ATOMRCF405NAVI target - #1174
Conversation
New target for the AtomRC F405 NAVI (STM32F405, BMI270, MAX7456, SD card). Ported from the INAV ATOMRCF405NAVI target definition. Tested on real hardware: builds and flashes cleanly, gyro/acc/baro/mag detected, SD card blackbox working, fixed-wing mixer running 2 motors (S1/S2) and 3 servos (S3/S4/S5). Submitted under COMM as AtomRC is not a registered manufacturer ID.
WalkthroughAdds the ChangesATOMRCF405NAVI target
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@configs/COMM/ATOMRCF405NAVI/config.h`:
- Around line 50-52: Remove the conflicting USE_FLASH and USE_FLASH_W25Q128FV
definitions alongside USE_SDCARD if this board has no separate flash chip;
otherwise configure the flash with its actual SPI instance and a chip-select pin
distinct from SDCARD_SPI_CS_PIN/PB6.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b1d7cdd-e8dc-4513-b964-1920de69a24f
📒 Files selected for processing (1)
configs/COMM/ATOMRCF405NAVI/config.h
Remove SPI flash defines (board has SD card only)
New target for the AtomRC F405 NAVI (STM32F405, BMI270, MAX7456, SD card). Ported from the INAV ATOMRCF405NAVI target definition.
Tested on real hardware: builds and flashes cleanly, gyro/acc/baro/mag detected, SD card blackbox working, fixed-wing mixer running 2 motors (S1/S2) and 3 servos (S3/S4/S5).
Submitted under COMM as AtomRC is not a registered manufacturer ID.
Pull-Request requirements
Mandatory Review for All New Flight Controllers
Hardware Compliance Requirements
These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.
If you have any questions or need guidance, feel free to reach out to the Betaflight development team.
Housekeeping
master.Checklist (✓/✕, or y/n)
Summary by CodeRabbit