Add DEEPSPACEH7AIO - #1121
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdds the DEEPSPACEH7AIO STM32H743 Betaflight target configuration with ICM42688P, DPS310, flash, MAX7456 OSD, board pin mappings, timer/DMA settings, peripheral instances, and default control settings. ChangesBoard Configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@configs/DEEPSPACEH7AIO/config.h`:
- Around line 131-132: The inline comments on the TIMER_PIN_MAP entries for PB14
(CAMERA_CONTROL_PIN) and PE5 (BEEPER_PIN) are incorrect — they reference
non‑existent TIMx_CH4 channels; open the STM32H743 datasheet / alternate
function table, confirm the correct timer and channel mapping for PB14 and PE5,
then update the comments on the two TIMER_PIN_MAP lines (the entries using
CAMERA_CONTROL_PIN and BEEPER_PIN) to reflect the correct TIMx_CHy names (e.g.,
TIM12_CHx or TIM15_CHy as appropriate) so the comment matches the MCU AF
mapping.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 29d9c427-7143-419b-aea5-ed12ed4de44f
📒 Files selected for processing (1)
configs/DEEPSPACEH7AIO/config.h
ADC_RSSI_PIN and ADC_EXTERNAL1_PIN pins are not connected to anything, only marked on the MCU pinout.
Board now aligns with silk screen arrow with board align set to default (all zeros)
I²C bus 2 was unused in the original schematic, but will be used for the external I²C pads in the mass produced PCB
|
Note betaflight/config moved from |
|
Need to move to manufacturer directory before merging. |
Checklist (✓/✕, or y/n)
Todo
Summary by CodeRabbit