fix(curl): parse -b/--cookie flag as Cookie header#81
Open
diegoQuinas wants to merge 2 commits into
Open
Conversation
Fixes berbicanes#66 The -b / --cookie flag was hitting the unknown-flag catch-all and being silently dropped along with its value. Added a match arm that reads the next token and inserts it as a Cookie header, consistent with how other value-consuming flags (-H, -d, -u) are handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When importing a curl command that uses
-bor--cookie, the flag and its value were silently dropped. No error was shown. Closes #66.Root Cause
In
parse_curl()(apps/desktop/src-tauri/src/http/curl.rs), the-b/--cookieflag hit the_ =>catch-all, which skipped the flag but left the cookie value to be mishandled by the next loop iteration.Fix
Added a match arm that consumes the next token and inserts it as a
Cookieheader — consistent with how-H,-d, and-uare handled.Testing
Added two unit tests: one for
-b(short form) and one for--cookie(long form). All 6 curl unit tests pass.