Consolidate staking pool landing into install.sh - #448
Open
camembera wants to merge 5 commits into
Open
Conversation
Single bastion entry point for self-funded and delegated landing; validator ops stay in install-helpers. Drop redundant register/activate scripts, env.sh generation, and plan-era naming. Harden lib-common logging and deposit validation for bash 3.2 and Ledger paste flows.
… defaults. Merge installer into install-helpers, drop legacy post-install scripts, add interactive defaults via env.sh, expand README and template, and fix shared address validation for delegator-delegate.sh.
Ask operators to confirm the beacond validate success line instead of exit 0, and exit explicitly from main after install or --help.
![semgrep-managed-scans-berachain[bot]](https://avatars.githubusercontent.com/u/96059542?s=60&v=4){kind=small}
3 tasks
The workflow only runs Prettier; foundry-toolchain was failing on a bad cached foundryup binary before that step ran. Format install-helpers README.
Semgrep flagged eval in run_cast_or_paste; build cast argv arrays and invoke cast directly for hot-key broadcasts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shflow ininstall-helpers/eth_chainId, deposits are validated on the validator host, and confirmed txs append tostaking-pool-receipts.jsonldelegator-delegate.shfor internal Foundation handler formation; drop standalone activate/deploy/status shell entrypointsCompanion docs PR: berachain/docs#98
Test plan
./install.sh(pool0xA9acE3Cf13D9609561eC3D8D472e3d9b70e64395)./install.sh --helpon a clean host with Foundrycast,jq, andcurlcast sendfor deploy/activateDelegationHandlerauto-detected;createStakingPoolWithDelegatedFundslanding