Update SQL queries in GetIngestDefinition to use COALESCE for no records returned - #87
Merged
Conversation
…mTimestamp and DataToTimestamp calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
GetIngestDefinition.sqlstored procedure to improve the handling of NULL values in timestamp and number-based delta queries. The changes ensure that when no data is present in the source tables, the resulting queries return fallback values instead of NULLs, making downstream processing more robust.Key improvements to NULL handling in generated SQL queries:
Delta Table Queries:
COALESCEonMINandMAXof the watermark columns, providing fallback values (such as the last known delta date or number) when no data is present. This prevents NULLs from being returned forDataFromTimestampandDataToTimestamp. [1] [2] [3]Running Number Queries:
COALESCEforMINandMAXvalues, defaulting to the last known delta number or calculated intervals, ensuring fallback values are always present. [1] [2]These changes make the stored procedure more resilient by guaranteeing that summary queries always return valid timestamps or numbers, even when the source data is missing.…mTimestamp and DataToTimestamp calculations