fix(nomantim): modify address autocomplete to only include California addresses#217
fix(nomantim): modify address autocomplete to only include California addresses#217v7ncentng wants to merge 12 commits into
Conversation
…addresses & Increased Nominatim fetch limit from 5 to 10 so more California results survive the state filter. Ran npx --prettier write .
…ifornia addresses" This reverts commit 247aeea.
Wired up the two-step flow properly: a. CSVUploadOverlay now gets onFileSelect, which calls openImportModal(file) from useCSVImport to parse the CSV. b. CSVImportModal renders once parsing succeeds, receives csvData and importAddresses to complete the import.
|
The Nominatim changes look solid — the viewbox + bounded=1 + post-filter layering is a reasonable approach and the 1. This new 745-line file is never imported. Both callers still point at
If this was meant to be a location refactor, the two import paths need updating. If not, the file should be deleted — it'll otherwise sit in the bundle unexecuted. 2.
3. The PR removes |
…rror Deletes the unimported CSVImportModal, removes duplicate style rules in upload-save-point, restores the missing aria-label="Remove" button attribute, and excludes playwright.config.ts from the Next.js tsconfig to fix the build type error.
Summary
Motivation
Changes
Frontend
app/ui/next.config.ts: Addedturbopack: { root: __dirname }so Turbopack resolves modules relative toapp/ui/rather than a parent directoryapp/ui/src/app/components/AddressGeocoder/utils/nominatim.ts:viewbox=-124.48,42.01,-114.13,32.53) withbounded=1to restrict Nominatim search to California at the API leveladdress.state === "California"as a safety net for any edge-case results that slip through the viewboxValidation
Frontend
npm --prefix app/ui run lintnpm --prefix app/ui run format:checknpm --prefix app/ui run typechecknpm --prefix app/ui run testnpm --prefix app/ui run buildnpm --prefix app/mobile run lintnpm --prefix app/mobile run typecheckBackend
cmake --preset dev.github/scripts/check-backend-static.sh build/devcmake --build --preset dev --parallelctest --preset dev --output-on-failure --no-tests=error -LE 'e2e|docker'docker compose -f deploy/compose/docker-compose.arm64.yml --env-file deploy/env/http-server.arm64.env configRisk
address.statestring (e.g. abbreviations). Monitored via manual QA on a few known CA addresses.Rollout and Recovery
turbopack: { root: __dirname }fromnext.config.tsand pinnext devwith--no-turbopackas a temporary workaround.viewbox,bounded, andfilteradditions fromautocompleteAddressinnominatim.ts.High-Signal PR Checklist