feat(ui): improve delivery time handling#214
Open
Gill87 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
00after a valid hour is entered, allowing common on-the-hour departures to save without an extra manual minute entry.From <time>, end-only windows showBy <time>, full ranges and empty windows keep their prior display.Motivation
Changes
00only for valid hours from1through12.00was generated by the UI so user-entered minutes, including a deliberate00, are not overwritten.Validation
Frontend
npm --prefix app/ui test -- deliveryHelpers.test.ts— passed: 1 test file, 10 tests.npm --prefix app/ui run typecheck— passed.npm --prefix app/ui test— passed: 24 test files, 122 tests.npm --prefix app/ui run lint— skipped locally; CI will run the full lint gate for the branch.npm --prefix app/ui run format:check— skipped locally; CI will run the formatting gate for the branch.npm --prefix app/ui run build— skipped locally; CI will run the production build gate for the branch.Other Checks
npm --prefix app/mobile run lint— skipped locally because the mobile app is outside this UI change.npm --prefix app/mobile run typecheck— skipped locally because the mobile app is outside this UI change.cmake --preset dev— skipped locally because backend code is outside this UI change..github/scripts/check-backend-static.sh build/dev— skipped locally because backend code is outside this UI change.cmake --build --preset dev --parallel— skipped locally because backend code is outside this UI change.ctest --preset dev --output-on-failure --no-tests=error -LE 'e2e|docker'— skipped locally because backend code is outside this UI change.Risk
Rollout and Recovery
High-Signal PR Checklist