fix(driver): show invalid route upload errors on upload page#212
Open
hir-al-14 wants to merge 1 commit into
Open
fix(driver): show invalid route upload errors on upload page#212hir-al-14 wants to merge 1 commit into
hir-al-14 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/upload-routeinstead of sending drivers to the deprecateddriver_assisttester upload screen.Motivation
/driver_assist, which exposed an old unstyled fallback upload UI.Changes
Frontend:
/upload-routevalidation that parses and transforms route uploads before navigating./upload-routeerror block./upload-routeinstead of rendering the deprecated fallback screen.Backend: No backend changes.
Validation
Frontend
npm.cmd --prefix app/ui run lintnpm.cmd --prefix app/ui run format:checknpm.cmd --prefix app/ui run typechecknpm.cmd --prefix app/ui run testnpm.cmd --prefix app/ui run buildnpm.cmd --prefix app/mobile run lintnpm.cmd --prefix app/mobile run typecheckBackend
cmake --preset dev.github/scripts/check-backend-static.sh build/devcmake --build --preset dev --parallelctest --preset dev --output-on-failure --no-tests=error -LE 'e2e|docker'Risk
/driver_assist./upload-routewith the existing styled error UI.Rollout and Recovery
High-Signal PR Checklist
Related Issues
#198
/upload-routeshows an error on/upload-route./driver_assist.