Skip to content

ignore extra env variables for task input hash #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuzuleinen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ignore extra env variables for task input hash #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions bobtask/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,7 @@ func (t *Task) description() string {
// env is influenced by t.dependencies, so no need to hash t.dependencies
sort.Strings(t.env)
for _, v := range t.env {
// ignore buildCommandPath and SHLVL due to non-reproducibility
v = strings.ToLower(v)
if strings.HasPrefix(v, "buildcommandpath=") {
continue
}
if strings.HasPrefix(v, "shlvl=") {
if shouldIgnore(v) {
continue
}
sb.WriteString(v)
Expand All @@ -214,3 +209,28 @@ func (t *Task) description() string {

return sb.String()
}

// shouldIgnore checks if the key-value env pair
// should be ignored from the task description due to non-reproducibility
func shouldIgnore(v string) bool {
v = strings.ToLower(v)
if strings.HasPrefix(v, "buildcommandpath=") {
return true
}
if strings.HasPrefix(v, "shlvl=") {
return true
}
if strings.HasPrefix(v, "home=") {
return true
}
if strings.HasPrefix(v, "logname=") {
return true
}
if strings.HasPrefix(v, "pwd=") {
return true
}
if strings.HasPrefix(v, "user=") {
return true
}
return false
}