Restructures & Improvements for Sugar.#9
Open
ShindouMihou wants to merge 7 commits into
Open
Conversation
added 6 commits
November 8, 2023 02:27
ShindouMihou
changed the title
ayubun
approved these changes
Dec 26, 2023
ayubun
left a comment
ayubun
left a comment
Member
There was a problem hiding this comment.
nice :D i have nits, but i just wanted to review cuz i'm a bit bored 😆
Member
There was a problem hiding this comment.
were you the original author of these changes, or was it lyus? :o
whoever it was must really not like semicolons 😆
Member
Author
There was a problem hiding this comment.
Originally, Sugar was under Lyus, but I took over and basically did it from scratch. Hey, it's hard to write semicolons as someone who's been writing Kotlin for a long while now 😆 It doesn't help that Golang also doesn't use semicolons nor does JS/TS enforce it lel
Member
There was a problem hiding this comment.
We might just set up Prettier so that we don't have to worry about formatting lul
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admittedly, the prior code of sugar wasn't really the best, nor is it going to be the best right now, but this pull request should fix a lot of the issues and add some improvements, such as:
JSONNode methods over hardcoding JSON (resolved theBigIntissue).There are no plans to adjust Sugar into a centralized subscriptions handler for now, as the only module it communicates with right now is Tea. Although, that might change in the future, for better maintenance right now, reducing the complexity to this much should be fine.