Fix ArrayBase::operator!= for equal arrays#2420
Open
cuiweixie wants to merge 1 commit intobeefytech:masterfrom
Open
Fix ArrayBase::operator!= for equal arrays#2420cuiweixie wants to merge 1 commit intobeefytech:masterfrom
cuiweixie wants to merge 1 commit intobeefytech:masterfrom
Conversation
The last branch returned true when sizes and elements matched; return false so equal arrays compare unequal only when they actually differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayBase::operator!=returnedtruein the success path when both arrays had the same size and elements. The finalreturnshould befalsewhen all pairs match.Change
BeefySysLib/util/Array.h: last branch ofoperator!=now returnsfalsewhen contents are equal.Matches the same logic as
operator==(equal sequences are not unequal).