fix(frontend): require string externalization for multi-locale targets#32
Merged
Merged
Conversation
An end-to-end build against issue #28 (EQ Preset Studio, Qt Quick, github.com/beefiker/qt-audio-eq) reproduced complaint 3: the skill shipped hardcoded single-locale copy for an open-source distribution target and even recorded the mismatched language in visual QA without treating it as a finding. The contract covered localization only as layout survival (CJK/RTL/long translations), never as a string externalization obligation. Name the obligation in the shared i18n contract and the Qt checklist: distribution-targeted surfaces ship every user-visible string through the platform translation mechanism from the first artifact, and a shipped language that differs from the brief's records its locale decision. Pin both in the contract test and bump to 0.12.1.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/ux.md): when the brief, audience, or distribution intent implies more than one locale, every user-visible string ships through the platform translation mechanism from the first artifact, and hardcoded single-locale copy in a distribution-targeted surface is a defectreferences/qt.md) and pin both intest/frontend-ux-contract.test.jsWhy
An end-to-end verification build against issue #28 (EQ Preset Studio, Qt Quick, https://github.com/beefiker/qt-audio-eq) reproduced complaint 3 exactly: a Korean brief with stated open-source distribution intent produced an English-only UI with zero
qsTr(), no translation setup, and a visual-QA report that noted the mismatched language without flagging it. The existing contract treats localization as layout survival (CJK/RTL/long translations must not clip) but never obligates externalizing strings, so the model satisfied the letter of the contract while re-committing the original issue.Validation
npm test— 654/654 passed