feat(frontend): expand cross-platform UX coverage#29
Merged
Conversation
beefiker
marked this pull request as ready for review
July 21, 2026 05:36
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Split the symlink-dependent evidence-root assertions into their own test with the repository's established win32 skip guard, so the portable create/verify coverage still runs when symlink creation is unavailable.
Scoped-row identity previously hashed target.id + owner only, so two rows sharing one generic id (e.g. desktop) on distinct platforms were falsely rejected as duplicates even though the validators accept generic ids distinguished by platform. Key dedup and artifact attribution by id + platform + owner, pin the behavior in a dedicated golden test file (the per-gate golden files sit at the reviewability cap), and align the gate notes, audits, and doc contracts.
The passive Timeline/Inbox items render their SVGs through a plain QML Image, which cannot tint currentColor strokes; QtSvg resolved them to black on the dark sidebar. Stroke the two sidebar-only icons with the sidebar text tone; the existing 0.72 opacity keeps the muted look.
Proportional selection left every anti-slop row self-waivable with a bare reason. Name a minimal core that stays binding whenever the contract is selected: honest assets, no shipped placeholders, named waiver authority, and grounded impact-unchanged records.
The base-unit regex matched inside words like baseline or database, so prose such as 'baseline is aligned to a 3px sub-grid' ahead of the real 'base 4px scale' line silently set the wrong base and skewed every off-scale spacing verdict. Require the standalone word and pin the baseline/database cases.
The reuse message still described slices as target/owner pairs after identity became platform-aware, mislabeling rows that differ only by platform as having distinct targets. Say target/platform/owner slices and pin cross-platform artifact exclusivity for one target id in both gate shapes.
Name anti-slop.md in the claim-triggered overlay list so campaign and editorial deliveries discover it from SKILL.md instead of only through web.md, and record in the two fixed-tone icons that their stroke mirrors Theme.sidebarText.
An A/B/A test on a real Codex host (implicit prompt with and without the block, plus an explicit invocation) showed allow_implicit_invocation changes nothing: implicit activation is already suppressed by the explicit-only default_prompt contract, and explicit invocation works either way. Keeping an unrecognized key implies manifest-level enforcement that does not exist, so remove it and pin the file to interface-only metadata.
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Addresses #28.
Issue #28 surfaced dummy controls, excessive manual input, omitted i18n, desktop SEO misrouting, weak Undo/persistence/reachability behavior, and misleading read-only fields. This change promotes those concerns into shared UX contracts that can govern supported screen-based application UIs rather than Web alone.
The latest follow-up is covered without turning one profile editor into a universal UI recipe:
Validation
CODEX_HOME=<isolated> npm test— 646/646 passednpm pack --dry-run --json— version 0.11.0; 506 files; changed skill contracts and focused semantics test presentgit diff --check origin/main...HEAD— cleanKnown review findings before merge
This PR remains a draft until the following review findings are addressed: