Bugfix/page import qt5#34
Open
seb5g wants to merge 3 commits into
Open
Conversation
wakonig
reviewed
May 10, 2026
Member
wakonig
left a comment
wakonig
left a comment
There was a problem hiding this comment.
Thanks! - let's just change it to qtpy's dependency flags and then we merge it.
| import logging | ||
|
|
||
| from qtpy.QtWebEngineCore import QWebEnginePage | ||
| try: |
Member
There was a problem hiding this comment.
Instead of try/except, I would suggest using qtpy's PYQT5 flag
Member
There was a problem hiding this comment.
also, please use "conventional commits" (rather a new feature in this case, so "feat:"). More info can be found here: https://www.conventionalcommits.org/en/v1.0.0/
Patch the QWebEnginePage import difference between pyqt5 on one hand and pyqt6/pyside6 on a second hand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the use of pyqt5 as a backend. The main difference is the import of the QWebEnginePage class from different modules.
Type of Change
How to test
Potential side effects
nothing