Feature/scan bundler device progress

[wakonig]

Description

This PR merges the scan progress update for monitored readouts and device progress into a single update for "scan progress". The scan bundler now automatically subscribes to the device for the scan and forwards the update accordingly.

Related Issues

How to test

• Run unit tests
• Run a scan with device progress and one with normal monitored progress. Check the plugin repo for a scan with device progress.

Additional Comments

Once merged, we can simplify the subscription logic in BW.

[codecov]

Codecov Report

❌ Patch coverage is 71.95122% with 23 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
bec_server/bec_server/scan_bundler/scan_bundler.py	27.27%	16 Missing ⚠️
bec_server/bec_server/scan_bundler/bec_emitter.py	88.33%	2 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR adds support for reporting scan progress based on a device’s progress signal (via scan queue report_instructions), instead of always deriving progress from emitted scan points. It wires scan-queue-status handling into the ScanBundler and extends the BECEmitter to subscribe/unsubscribe to device progress topics and emit scan progress accordingly.

Changes:

• Subscribe ScanBundler to scan_queue_status and extract per-scan report_instructions into scan_report_instructions.
• Update BECEmitter to optionally subscribe to device_progress/<device> and use that to emit scan progress (including cleanup/unsubscribe paths).
• Extend scan bundler emitter tests to cover device-progress subscription behavior and cleanup.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
bec_server/bec_server/scan_bundler/scan_bundler.py	Track scan report instructions from scan queue status updates; trigger emitter cleanup earlier in storage cleanup.
bec_server/bec_server/scan_bundler/bec_emitter.py	Add device-progress-based scan progress reporting, subscription management, and last-progress emission on completion.
bec_server/tests/tests_scan_bundler/test_bec_emitter.py	Add/adjust unit tests covering device-progress subscriptions and scan progress emission behavior.

Comments suppressed due to low confidence (2)

bec_server/bec_server/scan_bundler/scan_bundler.py:400

• scan_report_instructions is stored per scan id but never removed during cleanup. This can accumulate stale entries and leak memory across scans. Include it in the cleanup storages list.

            for storage in [
                "sync_storage",
                "monitored_devices",
                "baseline_devices",
                "readout_priority",
            ]:

bec_server/bec_server/scan_bundler/scan_bundler.py:400

• scan_report_instructions is stored per scan id but never removed during cleanup. This can accumulate stale entries and leak memory across scans. Include it in the cleanup storages list.

            for storage in [
                "sync_storage",
                "monitored_devices",
                "baseline_devices",
                "readout_priority",
            ]:

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.