Recreate #488: pnpm v11 upgrade + nuxt-pay/nuxt-auth preview swap for corps/person-roles/registry-home#516
Open
panish16 wants to merge 8 commits into
Open
Recreate #488: pnpm v11 upgrade + nuxt-pay/nuxt-auth preview swap for corps/person-roles/registry-home#516panish16 wants to merge 8 commits into
panish16 wants to merge 8 commits into
Conversation
…w exotic sources in pnpm workspace
# Conflicts: # .github/workflows/registry-home-ci.yaml # packages/layers/base/package.json # pnpm-lock.yaml # pnpm-workspace.yaml
…ilds placeholders Recreates bcgov#488 (closed, unmerged) on top of current main, which has moved on since (bcgov#513's typecheck jobs and vue-version-collision override). Specific fixups beyond the merge itself: - Replace `latest-11`/bare version pnpm/action-setup inputs with an exact 11.9.0 pin across all CI workflows and the new typecheck jobs bcgov#513 added (still on pnpm/action-setup@v4 + 10.0.0) — matches the pattern already proven across this org's pnpm v11 migration: mixing a resolver keyword with an explicit packageManager field risks "Multiple versions of pnpm specified" errors. - Remove the now-redundant "pnpm" key from root package.json — its vue overrides already live in pnpm-workspace.yaml via bcgov#513's fix, and pnpm v11 silently ignores the package.json key entirely. - Fix two allowBuilds entries pnpm auto-scaffolded with literal "set this to true or false" placeholder text for the pkg.pr.new URL-referenced @sbc-connect packages. - Bump corps/person-roles/registry-home packageManager to 11.9.0 for consistency with the rest of this migration.
panish16
requested review from
deetz99,
doug-lovett,
eve-git,
kialj876,
pwei1018,
thorwolpert and
vysakh-menon-aot
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recreates #488 (closed, unmerged, originally by @pwei1018) on top of current
main, which has moved on significantly since (notably #513's typecheck jobs and vue-version-collision fix).corps,person-roles, andregistry-homeCI workflows to pnpm 11.9.0 (actions/checkout@v6,pnpm/action-setup@v6,actions/setup-node@v6, exact11.9.0version pin rather than thelatest-11keyword, which risks "Multiple versions of pnpm specified" errors when combined with an explicitpackageManagerfield).pnpm-workspace.yaml'sonlyBuiltDependencies→allowBuilds(pnpm v11's replacement format) and folds inblockExoticSubdeps: false, needed because the@sbc-connect/nuxt-pay/nuxt-authpreview packages below reference each other via URL.@sbc-connect/nuxt-pay/nuxt-authto theirpkg.pr.newpreview builds (from update pnpm version to latest-11 across CI workflows and package.json… #488's original intent)."pnpm"key from rootpackage.json(pnpm v11 silently ignores it; the same overrides already live inpnpm-workspace.yamlvia 34023 - fix type errors and add typecheck to CI's #513).packageManagertopnpm@11.9.0forcorps/person-roles/registry-homefor consistency with the rest of the org-wide pnpm v11 migration (tracked separately in chore: upgrade packageManager to pnpm@11.9.0 #504).Test plan
corps-ui-ci,business-people-ui-ci,registry-home-ui-ci,layers-base-ci,changesetstypecheckjobs pass on pnpm 11.9.0