feat: Add BC Notify and BC Notify Housing services.#287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are the addition of BC Notify as a notification provider (with feature flags for dynamic selection), implementation of SSRF protections for file downloads, improved logging for database operations, and updates to email validation and its tests.
Notification Provider Enhancements:
Added BC Notify and BC Notify Housing as notification providers
Security Improvements:
Replaced requests with httpx for outbound HTTP requests and implemented SSRF protections in download_file, restricting downloads to public http/https URLs and enforcing size/time limits.
Error Handling and Logging:
Improved error handling in database operations for callbacks and safe list management, adding structured logging for failures.
API and Testing Updates:
Updated the email validation endpoint to require authentication and refactored preflight handling for CORS. Tests were updated to inject valid tokens and to mock httpx instead of requests.
Other Improvements:
Minor code cleanups and improved documentation/comments throughout the codebase.