Skip to content

feat: Add BC Notify and BC Notify Housing services.#286

Closed
pwei1018 wants to merge 3 commits into
bcgov:mainfrom
pwei1018:feature-bc-notify
Closed

feat: Add BC Notify and BC Notify Housing services.#286
pwei1018 wants to merge 3 commits into
bcgov:mainfrom
pwei1018:feature-bc-notify

Conversation

@pwei1018

@pwei1018 pwei1018 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

The changes are the addition of BC Notify as a notification provider (with feature flags for dynamic selection), implementation of SSRF protections for file downloads, improved logging for database operations, and updates to email validation and its tests.

Notification Provider Enhancements:

  • Added BC Notify and BC Notify Housing as notification providers

Security Improvements:

  • Replaced requests with httpx for outbound HTTP requests and implemented SSRF protections in download_file, restricting downloads to public http/https URLs and enforcing size/time limits.

Error Handling and Logging:

  • Improved error handling in database operations for callbacks and safe list management, adding structured logging for failures.

API and Testing Updates:

  • Updated the email validation endpoint to require authentication and refactored preflight handling for CORS. Tests were updated to inject valid tokens and to mock httpx instead of requests.

Other Improvements:

  • Minor code cleanups and improved documentation/comments throughout the codebase.

@pwei1018 pwei1018 closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant