chore: upgrade pnpm to latest-11 in CI workflows#282
Open
panish16 wants to merge 6 commits into
Open
Conversation
…by pnpm v11 pnpm v11 stopped reading package.json's "pnpm" key in document-service/documents-ui, silently dropping 8 dependency overrides and causing a lockfile mismatch. Move both overrides and build-script approvals to pnpm-workspace.yaml, with an explicit empty packages list since the production lint job's older pnpm still requires that field to be present.
The extended business-dashboard-ui layer's install: true option caused an infinite install/nuxt-prepare loop once a pnpm-workspace.yaml was present (same class of issue as unjs/c12#128), hanging until CI's timeout killed the job. Disable it; the layer's own runtime deps are already satisfied via this app's existing dependencies.
The shared bcregistry-sre/frontend-ci.yaml workflow defaults pnpm_version to "9" when unset, and pnpm/action-setup doesn't defer to packageManager for that bare default. Pin pnpm_version to 11.9.0 explicitly, matching packageManager, as a stopgap until bcgov/bcregistry-sre#369 lands.
Now that documents-ui-ci actually runs pnpm 11 (previous commit), verify-build and unit-testing-pnpm surface missing modules used by the extended business-dashboard-ui layer (moment, @bcrs-shared-components/ enums+interfaces, @vuepic/vue-datepicker, @vueuse/core, country-list, lodash.isdate/isequal/omit, uuid) that were previously satisfied only via c12's now-disabled install:true auto-install. Declare them directly, matching the layer's own pinned versions (tag v0.0.1). Verified locally: clean install, full build, and all 19 unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates pnpm version references in GitHub Actions workflows from v10 to
latest-11. Part of pnpm v11 upgrade (ticket #33875).package.jsonpackageManagerfield was updated in a separate PR.