chore: upgrade packageManager to pnpm@11.9.0#271
Open
panish16 wants to merge 7 commits into
Open
Conversation
Move build-script approvals from package.json's dead "pnpm" key to pnpm-workspace.yaml (with an explicit empty packages list, since the production lint job's older pnpm still requires that field to be present), and drop the redundant pnpm/action-setup version input that now conflicts with packageManager. Note: bcregistry-ui-ci's linting job remains blocked on bcgov/bcregistry-sre#369, which still hardcodes pnpm v9 in a shared reusable workflow.
The shared bcregistry-sre/frontend-ci.yaml workflow defaults pnpm_version to "9" when unset, and pnpm/action-setup doesn't defer to packageManager for that bare default. Pin pnpm_version to 11.9.0 explicitly, matching packageManager, as a stopgap until bcgov/bcregistry-sre#369 lands.
Now that bcregistry-ui-ci actually runs pnpm 11 (previous commit), the verify-build job surfaces "Can't resolve 'tailwindcss'" — it's a transitive dependency (via @sbc-connect/nuxt-core-layer-beta) resolved in the lockfile at 4.1.5 but not reachable from this app's own node_modules. Declare it directly, matching the resolved version.
Now that bcregistry-ui-ci actually runs pnpm 11, verify-build surfaces "Can't resolve '@nuxt/ui'" and would hit further missing modules one at a time. Declare the full set of the extended layer's own dependencies directly (@nuxt/ui, @pinia/nuxt, @vueuse/nuxt, pinia, pinia-plugin-persistedstate, keycloak-js, launchdarkly-vue-client-sdk, dompurify, jsdom, maska, zod, @iconify-json/mdi), matching the layer's pinned versions. Verified locally: clean install, vite build completes successfully (remaining local-only failure is the known Windows better-sqlite3 native-binding limitation, irrelevant on Linux CI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
packageManagertopnpm@11.9.0inpackage.jsonas part of the pnpm v11 upgrade (ticket #33875). CI trigger already updated topnpm@11.9.0.