PSP-11664 Remove Contractor Permissions for Specified Region#5354
PSP-11664 Remove Contractor Permissions for Specified Region#5354asanchezr wants to merge 13 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| }; | ||
|
|
||
| var context = helper.CreatePimsContext(user, true).AddAndSaveChanges(contractorFile); |
| } | ||
| }; | ||
|
|
||
| var context = helper.CreatePimsContext(user, true).AddAndSaveChanges(outOfRegionFile); |
| } | ||
| }; | ||
|
|
||
| var context = helper.CreatePimsContext(user, true).AddAndSaveChanges(inRegionFile); |
| // Assert | ||
| // PersonId should be passed to ensure contractor only sees leases they are assigned to | ||
| leaseRepository.Verify(x => x.GetPage(filter, user.PersonId), Times.Once); | ||
| leaseRepository.Verify(x => x.GetPage(filter, It.Is<UserContextModel>(uc => uc.PersonId == user.PersonId && uc.IsContractor == true)), Times.Once); |
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5354 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5354 |
eddherrera
left a comment
eddherrera
left a comment
There was a problem hiding this comment.
Although the code looks good I am moderately concerned about the fact that methods at the repository level became heavily dependent and tightly coupled on a "UserContext" which may not always be the case when have other services making calls to the API.
I see other changes not related to the scope of the ticket like 'Appsettings' and 'project' settings and changes on ports configurations that would have been better on a sepparate PR.
And the last thing would be the TICKET number in comments, which I believe we don't have a convention and would be nice to agree upon.
Please take a note on the project settings changes and communicate to us on the Dev meeting.
|
Tick the box to add this pull request to the merge queue (same as
|
3 participants
No description provided.