Skip to content

PSP-11709, PSP-11711, PSP-11712: BVT Observations Primary Contact associated with an Organization contact#5352

Merged
stairaku merged 9 commits into
bcgov:devfrom
stairaku:PSP-11709
Jul 9, 2026
Merged

PSP-11709, PSP-11711, PSP-11712: BVT Observations Primary Contact associated with an Organization contact#5352
stairaku merged 9 commits into
bcgov:devfrom
stairaku:PSP-11709

Conversation

@stairaku

@stairaku stairaku commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@stairaku stairaku requested review from asanchezr and eddherrera July 9, 2026 00:19
@stairaku stairaku self-assigned this Jul 9, 2026
@stairaku stairaku added the bug Something isn't working label Jul 9, 2026
onDeleteContact,
}) => {
const keycloak = useKeycloakWrapper();
const [person, setPerson] = useState<ApiGen_Concepts_Person | null>(null);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All state management should be placed in the Container. (i.e. ManagementSummaryContainer)

? first(managementFile.noticeOfClaim)
: null;

const {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fetch and repository calls should be placed in the Container. (i.e. ManagementSummaryContainer)

const { hasClaim } = useKeycloakWrapper();
const query = useQuery();
const history = useHistory();
const [person, setPerson] = useState<ApiGen_Concepts_Person | null>(null);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All state management and repository calls should be placed in the Container. (i.e. PropertyManagementDetailContainer)

@eddherrera eddherrera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and apply our stablished patterns.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5352

@stairaku stairaku requested a review from eddherrera July 9, 2026 19:57
@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@stairaku stairaku enabled auto-merge July 9, 2026 22:28
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5352

@stairaku stairaku added this pull request to the merge queue Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5352

Merged via the queue into bcgov:dev with commit 0e5722a Jul 9, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants